search

Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

Album view adjust #191

Closed Walikdik closed 4 years ago

ramack commented 4 years ago

thanks for your PR. As this is quite UI based (surprise surprise :-) it is hard to review it just by watching the code. Also the many commits don't make it easier. I'll have to try that one first but please give me a few days. @voriondev if you have time and want to give it a try don't hesitate to review it.

You might want to amend the commits or cancel the PR and create a fresh, clean one to simplify it if you have time. Also it seems you have added a dependency to a library. Are you sure that this is 1. needed and 2. a maintained one? And please add it in the about view (only in strings.xml) as used library.

ramack commented 4 years ago

ah and don't forget to put you there as a contributor

Walikdik commented 4 years ago

Hi @voriondev, I added a new commit where : conflicts were resolved, followed your instructions and made changes, also I reworked view. Review and let me know if it is okey. Thanks

Walikdik commented 4 years ago

Once again thank you for your contribution. There are, to me, still a few bugs needing your attention. First of all, the image scale is pretty strange on portrait images (see screenshot below).

Also, we can only open an album by clicking on the picture, when we should be able to open it by clicking anywhere on the ticket. Finally, I don't know @ramack's opinion about this, but you may want to close this PR and open another one with only the needed commits :)

I can not figure out how to solve image scaling. You want square preview but this should be also issue for portrait images, am I right? Maybe this could be right solution? FinalStrip

ramack commented 4 years ago

this is superseded by #210 so let's discard this one here.