search

Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

Mugshot support #216

Open sridharb1 opened 4 years ago

sridharb1 commented 4 years ago

There is an extension called mugshot which outlines people's faces when the mouse hovers over them. It would be really nice if the app version supported this feature. Ideally, it should use the data (in the database tables) that mugshot uses so that the face dimensions are captured once (for browser and app).

ramack commented 4 years ago

Thanks for the proposal, it is highly appreciated and it would be great to support it. So far there are a few other priorities to be cared about first but I really would like to support it.

What makes me wonder is whether the plugins expose their data via REST API, otherwise it will be hard to support it. Also we have to care about the two available plugins facetag and mugshot as long as one it not 'officially' deprecated...

sridharb1 commented 4 years ago

I don't know about the facetag plugin, but the mugshot plugin has a REST API. If you are talking about the mugshot plugin not being officially deprecated, no, it is not. But I mean that only half-heartedly in the sense that the developer has not shown any interest in fixing things and thus, it would unofficially have to be adopted by either the piwigo team or piwigo-android/mobile team to take it forward.

I think the mugshot plugin provides "more" functionality and thus is a better candidate for taking forward.

ramack commented 4 years ago

I personally installed facetag long ago and mugshot is based on it and claims to have more features. This is already a not so nice situation, as clearly it is good to support such an extension, but it's not worth to care about two different variants. So I'd appreciate if the community could somehow "agree" on one of them and find a new maintainer, if currently unmaintained. Then it makes sense to support in the apps, before I fear that we generate effort and with a future release of piwigo it might break and nobody will fix it.

Don't get me wrong, I don't want to just grumble around, just avoid useless effort.

sridharb1 commented 4 years ago

Yes, you are right. They are similar in functionality, but mugshot claims to be better. However, both seem to be dormant. The plugin itself is very straightforward (simple). I have requested piwigo to adopt this officially, but if not, could the app teams adopt it and take it forward (as in fix something that might break with future piwigo incompatible changes, that's all. Features can be thought of only as people's interest/time availability).

ramack commented 4 years ago

This issue is related to #66 - which is for the facetag extension. It seems good to support only one of the two...

sridharb1 commented 4 years ago

The issue #66 is worded slightly broadly in the sense of being able to read/update faces in photographs. It is definitely worth doing. However, there is still no uniformity in the format. I use picasa which uses XMP tags to represent faces. Other programs do too, but I believe that they are different.

If you would like to go down this path (of supporting facetags embedded in XMP data), then I could guide you a little (especially wrt the picasa format, possibly duplicated in other google offerings).

If you would like to go down the extension path (my recommendation as that would keep it synchronized with the browser (or native piwigo)), then I am a little biased in suggesting that you choose mugshot. My data is already in that format (though, I believe that the data for the underlying formats are very similar and thus easily translatable from one to another).