search

Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

Remove logout menu item #229

Closed coolo closed 4 years ago

coolo commented 4 years ago

The logout functionality does not really match with the account manager. Login needs to happen transparently, our 'Login' screen is basically creating accounts. More cleanup to follow

coolo commented 4 years ago

there is no need to logout - it's just a stale session entry in the server, that it will prune regularly. The important part is login whenever we start. And this is implemented in #227

ramack commented 4 years ago

Mh, I never deeply thought about it, but I was somehow trained to logout - also due to security. And closing the door when leaving sounds reasonable. @plegall what do you think? Is it worth to spend some effort on calling logout on piwigo or is there no real benefit?

coolo commented 4 years ago

We can also logout on a timer - and for sure when we switch accounts.

plegall commented 4 years ago

The ability to logout is not useless at all, in my opinion. If you're logged in as admin on your Piwigo and your kid borrows your tablet, you'll be be pretty happy to be able to logout before giving the tablet :-) The ability to logout should not be removed.

To take a comparison, when I've finished using my bank application on my phone, I always click on the "log out" button.

Philio commented 4 years ago

Not sure if you're aware but you already have parental controls, multiple user accounts etc etc to handle the "kid borrowed the phone/tablet" scenario, it's not an app specific problem really but handled at the OS level.

On Sat, 11 Jan 2020 at 02:57, Pierrick Le Gall notifications@github.com wrote:

The ability to logout is not useless at all, in my opinion. If you're logged in as admin on your Piwigo and your kid borrows your tablet, you'll be be pretty happy to be able to logout before giving the tablet :-) The ability to logout should not be removed.

To take a comparison, when I've finished using my bank application on my phone, I always click on the "log out" button.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Piwigo/Piwigo-Android/pull/229?email_source=notifications&email_token=AAB2CGWS4I5N7VDHESZAX4DQ5DOLFA5CNFSM4KEW4Y32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVF6ZQ#issuecomment-573202278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2CGXR2FPPLMRN5BRIASDQ5DOLFANCNFSM4KEW4Y3Q .

ramack commented 4 years ago

ah, this brings in even another aspect, but logout as such would not really help, as long as the credentials are stored in the account... For such a use case I think we'd have to do more than just a "logout" option leaving us with a simple selection of the account to login again, so we should handle that one in a different issue.

The discussion here is more about the technical benefit of calling logout - e. g. if we switch accounts.

plegall commented 4 years ago

The discussion here is more about the technical benefit of calling logout - e. g. if we switch accounts.

OK, then no, it's not useful to explicitely logout. The session will be automatically purged. When I wrote scripts requesting the Piwigo API, I nearly never logout before exiting.

ramack commented 4 years ago

great, thanks for clarification. Then this RP closes #196.