Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

Drawer does not close on selecting 'Albums' #230

Closed coolo closed 4 years ago

coolo commented 4 years ago

Describe the bug and how to reproduce In main view, open the drawer and see 'Albums' preselected. If you click on it, nothing happens.

Expected behavior I expect the drawer to close and the app to stay on the view.

I tried to get my head around it, but I failed :(

ramack commented 4 years ago

Might be better to behave like you described, but it's not a big deal, so I think we can shift this to a later release.

coolo commented 4 years ago

yeah, no worries. I just thought it's an easy fix and gave up after several approaches :)

coolo commented 4 years ago

I also checked ankidroid (my favorite way to learn spanish :) and it has the same problem, so no hope to copy from there :)

ramack commented 4 years ago

this might be a feature, as the "albums" entry is selectable and by tapping on it again the user might expect to "deslect" it, but what should happen in that case?

coolo commented 4 years ago

I checked with gmail app and there the current folder is selected and if I tap on it again, the drawer just closes (as I expect)

coolo commented 4 years ago

Wikipedia app solves it rather smart: not showing the main activity in the drawer. As there is no other activity that renders the drawer, that's actually smart :)

ramack commented 4 years ago

That would be a simple solution, yes. I don't have a preference here. I neither "need" the Albums" entry in the drawer, nor do I care much if nothing happens after tapping it when already selected. So in my eyes everything from keeping what we have currently, fixing it to close the drawer or removing the entry completely is perfectly fine for me.

As it won't be a big (r)evolution for the app I am personally not so interested in working on it (sorry to be that honest) but I will happily review and merge a PR for it.

(If complains come from more users I might change my opinion here for sure)

coolo commented 4 years ago

I did not want to remove the album navigation as I would really like to switch between accounts/galleries a little easier than going over 'Manage accounts', so I kept looking for a better solution