search

Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
141 stars 43 forks source link

Add idle resource for login handling to verify we're idle #252

Closed coolo closed 4 years ago

coolo commented 4 years ago

This simplifies the tests as we do not need to sleep or retry

coolo commented 4 years ago

no worries, I struggle with it myself - the counting is quite fragile.

coolo commented 4 years ago

I'll pick this up again - let's see if I can revive my memories :)

coolo commented 4 years ago

Found the bug that plagued the counting - and it was actually a little older :)

coolo commented 4 years ago

I will

coolo commented 4 years ago

WTF happened in https://travis-ci.org/github/Piwigo/Piwigo-Android/jobs/734687439 ? The image under test was repeatedly downloaded and there seems to be in general a huge leak of database connections and files in the new album view.

coolo commented 4 years ago

This feels like it will become another monster PR - as I'm hunting bugs in all kind of areas :)

ramack commented 4 years ago

WTF happened in https://travis-ci.org/github/Piwigo/Piwigo-Android/jobs/734687439 ? The image under test was repeatedly downloaded and there seems to be in general a huge leak of database connections and files in the new album view.

Are you sure about that? I think we have too many HTTP-requests, that is true, but they are only checking for a change without downloading payload.

ramack commented 4 years ago

I merged it, as it already was an improvement like updating and I didn't want to provoke merge conflicts if I'd have done it in parallel. But we don't need to pay PRs, so I'm happy to merge further improvements in a new one :-)

coolo commented 4 years ago

There is too much happening in the wrong places, I would like to redo the album view based on the picasso example, which works much better. But sorry Ralf, if it takes 29 days to merge a PR you already approved, it kind of kills the fun

ramack commented 4 years ago

There is too much happening in the wrong places, I would like to redo the album view based on the picasso example, which works much better. But sorry Ralf, if it takes 29 days to merge a PR you already approved, it kind of kills the fun

I am sorry about that, I obviously misinterpreted your comment

This feels like it will become another monster PR

which I read as this PR will become a big one, so don't yet merge it... Also I think when I approved it it was still reading "WIP" and I missed that you renamed it. Otherwise I'd have merged it much earlier. Don't hesitate to ping me in such cases in future!