search

Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
141 stars 43 forks source link

Move allow clear text to network security config #256

Closed persandstrom closed 4 years ago

persandstrom commented 4 years ago

This PR enables android-piwigo to communicate with unsecure piwigo gallery on Android API level 28 and higher.

According to https://developer.android.com/guide/topics/manifest/application-element#usesCleartextTraffic the android:usesCleartextTraffic="true" flag is ignored if an Android Network Security Config is present, which it is. This applies for API level 24 and higher. For API level 27 and lower the default value is "true", so the flag is not needed in the Manifest.

persandstrom commented 4 years ago

I do not really understand why the tests fail, some assistance would be helpful if possible

ramack commented 4 years ago

Thanks for your contribution! The failing test doesn't seem to be linked to this, so we can merge it even with failing tests.