Piwigo / piwigo-bootstrap-darkroom

A mobile-ready and feature-rich theme for Piwigo photo gallery, based on Bootstrap 4
Apache License 2.0
84 stars 40 forks source link

Theme doesn't work with photo sphere plugin #227

Closed diba78 closed 5 years ago

diba78 commented 5 years ago

Hi all together,

i tried tu use the photo sphere plugin to view my insta360 photos with the Bootstrap Dark Theme.

The photo is tagged with the photo sphere tag

But it doesn't work when i try to open the photo (see picture).

With other themes like elegant or Bootstrap default the photo sphere plugin works fine.

Can anybody help me. Have i configure something wrong ?

Best regards

Dirk Bootstrap_dark_with_photosphere

mixman68 commented 5 years ago

On my side i removed two block {if $theme_config->social_pinterest} <a href="https://www.pinterest.com/pin/create/button/?url={$http_scheme}://{$smarty.server.HTTP_HOST}{$smarty.server.REQUEST_URI}&media={$http_scheme}://{$smarty.server.HTTP_HOST}{$smarty.server.REQUEST_URI}/../{$current.selected_derivative->get_url()}" onclick="window.open(this.href, 'pinterest-share', 'width=490,height=530');return false;" title="Pin on Pinterest"{if $theme_config->social_buttons} class="btn btn-sm btn-social btn-raised btn-pinterest"{/if}> <i class="fab fa-pinterest"></i>{if $theme_config->social_buttons} Pinterest{/if} </a> {/if} {if $theme_config->social_vk} <a href="https://vkontakte.ru/share.php?url={$http_scheme}://{$smarty.server.HTTP_HOST}{$smarty.server.REQUEST_URI}&image={$http_scheme}://{$smarty.server.HTTP_HOST}{$smarty.server.REQUEST_URI}/../{$current.selected_derivative->get_url()}" onclick="window.open(this.href, 'vk-share', 'width=490,height=530');return false;" title="Share on VK"{if $theme_config->social_buttons} class="btn btn-sm btn-social btn-raised btn-vk"{/if}> <i class="fab fa-vk"></i>{if $theme_config->social_buttons} VK{/if} </a> {/if}

the selected_derivative not exists with plugins which modifie the picture renderer

tkuther commented 5 years ago

@djgreg13 good finding! Disabling social integration in theme config should remove that block

mixman68 commented 5 years ago

I taken the problem in the another way

i have forked the photosphere and the embedded videos (both are same problem) and i populate the standard derivative object with the derivative generated by these plugin. Because these plugin define theirs derivative into a non standard derivative variable. I will submit PR on these projects for this.

But your fix resolve the problem if a creator of plugin forget to populate the derivative object, maybe there is another plugin with the same problem

Thanks you