search

Piwigo / piwigo-flutter-app

Piwigo mobile application for Android
GNU General Public License v2.0
82 stars 26 forks source link

Replace video_player with better_player #103

Closed yamanq closed 2 years ago

yamanq commented 2 years ago

Using both video_player and better_player results in Gradle failing to build the app.

Gradle Log:

Execution failed for task ':app:checkDebugDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class com.google.android.exoplayer2.ui.DownloadNotificationHelper found in modules jetified-exoplayer-core-2.17.0-runtime (com.google.android.exoplayer:exoplayer-core:2.17.0) and jetified-exoplayer-ui-2.15.1-runtime (com.google.android.exoplayer:exoplayer-ui:2.15.1)

     Go to the documentation to learn how to <a href="d.android.com/r/tools/classpath-sync-errors">Fix dependency resolution errors</a>.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 25s
Exception: Gradle task assembleDebug failed with exit code 1
Catfriend1 commented 2 years ago

Hi,

I'm sorry to report that I was never able to play video from my Piwigo 12.1 https server. Where can I get more diagnostic info why playback of "standard" mp4 video fails?

yamanq commented 2 years ago

Hi @Catfriend1, Are you able to play videos through the Piwigo website? If not, I recommend asking on the forums then opening an issue on Piwigo. If it's just causing issues through the flutter android app, then you can get more error info by building the app and running it in debug mode. I do this through Android Studio so I am not sure if there are other ways.

Catfriend1 commented 2 years ago

@yamanq videos play fine via browser and the Piwigo ClientPro Android app can also play them.

yamanq commented 2 years ago

In that case, you should open an issue in this repository. You can get more info by building the app and running it in debugger mode.

Edit: In my case, I do not even have videos configured on my instance, so this PR specifically targets the upload screen only, which used to use video_player. I will have some time to play around with this in a few weeks.