video playback shot in portrait mode should 'fit to screen" in portrait mode while maintaining original size ratio

Piwigo / piwigo-flutter-app

Piwigo mobile application for Android

GNU General Public License v2.0

82 stars 26 forks source link

video playback shot in portrait mode should 'fit to screen" in portrait mode while maintaining original size ratio #130

Closed truckerboy closed 1 year ago

truckerboy commented 2 years ago

Video playback should 'fit to screen" in landscape and portrait mode while maintaining original size ratio. Setting the ability to scale to fit screen as an option would be ideal. In current state some videos are way too small and barely visible in original size.

remi-martin commented 2 years ago

Hi, this should have been fixed in #29 , what version of Piwigo NG are you using ?

I'll still try to reproduce it on my side.

truckerboy commented 2 years ago

The issue is indeed fixed for videos taken in landscape mode. The issue remains for videos taken in portrait mode. Portrait mode videos stay in miniature size when phone is held in portrait mode. However when phone is rotated to landscape mode, it correctly fits the screen. So the issue only exists for portrait mode videos when phone is held in portrait mode. Correct behavior would be for video to stretch and fill the screen when portrait mode video is viewed in portrait mode.

remi-martin commented 2 years ago

hmmm, I have changed what, for me, could cause this issue. I have tried the solution with different video sizes and format ratio and it always fits ether height or width of the screen.

The patch should be rolling this week, I'll let you know when it's available so you can see if you still have the issue.

remi-martin commented 2 years ago

Piwigo NG 1.2.0 is out on Github and may close this issue

truckerboy commented 2 years ago

not fixed in 1.2.0. unchanged from Google Play version.

remi-martin commented 1 year ago

Alright, I'll get over it later for more testing

truckerboy commented 1 year ago

This issue can be closed. I am quite sure the fix was released several versions ago but as of Piwigo NG version 2.2.3, I can report the issue no longer exists.