Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
35 stars 35 forks source link

Wrong URL created for image in map - wrong category used #108

Closed IT-Sumpfling closed 8 years ago

IT-Sumpfling commented 8 years ago

Hi, the issue in #74 is still open. Seems like the order of merges was mixed up - ending WITHOUT the fix on main ... https://github.com/xbgmsharp/piwigo-openstreetmap/commits/master/include/functions_map.php

https://github.com/xbgmsharp/piwigo-openstreetmap/blame/master/include/functions_map.php#L207

xbgmsharp commented 8 years ago

The latest code and the path match: https://github.com/xbgmsharp/piwigo-openstreetmap/blob/master/include/functions_map.php#L207 or https://github.com/xbgmsharp/piwigo-openstreetmap/commit/40ead0621fe4f09ac7b1eb4b470ce874ef82ae48

Or are you saying it should ic.category_id instead of i.storage_category_id. When confirm I can update the code accordingly.

Thanks

IT-Sumpfling commented 8 years ago

Hi,

yes, according to ThomasDaheim in #74 and my own tests (I had the problem described there and changed my local code accordingly) it should be ic.category_id .

xbgmsharp commented 8 years ago

Thanks, Fix commited.

IT-Sumpfling commented 8 years ago

Small typo in your fix - you wrote i.category_id instead of ic.category_id Thanks for the quick reactions!

xbgmsharp commented 8 years ago

Oups sorry, done.