Closed mb1248 closed 10 years ago
Thanks for the patch and sorry for the delay. So you are using the square image as a marker on the map. Nice idea. I was thinking of using a custom image, but having an option to use the image itself is a nice idea. I never finish it because I could not figure a way to center it correctly.
You can see the comment code: https://github.com/mb1248/piwigo-openstreetmap/blob/91f3bc2c6af8c32a7f208c175a5e16a080528c26/osmmap2.php#L266
I would like to include both change as once as an option. What do you think?
I apply your patch and the same problem appear. The popup is not correctly center on the markers. I need to enable the option of custom marker and add an option to use pictures as markers.
Please review and test the code. I implement custom Pin/Marker support allowing the use of pictures as markers.
Great! Works good, except for the images the popup is shown 4px to wide left.
I like the preview map! What do you think about adding the pin preview in this map?
I put the pin preview in the separate configuration fieldset, next to his select box. The problem is that the tile preview is a single image, so it would need to be done via overlay.
yes, I thought about an overlay. Maybe it gives a better feeling how it looks on a map, but it is not so important.
2014-04-15 10:34 GMT+02:00 xbgmsharp notifications@github.com:
I put the pin preview in the separate configuration fieldset, next to his select box. The problem is that the tile preview is a single image, so it would need to be done via overlay.
— Reply to this email directly or view it on GitHubhttps://github.com/xbgmsharp/piwigo-openstreetmap/pull/19#issuecomment-40457556 .
Thanks for the feedback. Feature add via commit d2a0224 Regarding the pin preview in this map preview, I might do it via a separate issue log. Closing.
Replacing of the blue markers with the picture.