search

Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
35 stars 35 forks source link

Update for Piwigo 11.2? #192

Closed DouglasAlden closed 2 years ago

DouglasAlden commented 3 years ago

Are there any plans in the works to update the extension to support the latest version of Piwigo 11.2?

jdbonjour commented 3 years ago

Very good plugin, thanks. But yes, it should be certified for Piwigo 11.x

bru500 commented 3 years ago

Yes, updated Piwigo to 11.x. Now it looks a bit sad, because OpenStreetMap got disabled.. Great plugin, thank you!

willemjaap commented 3 years ago

agree; if I can be of assistance in coding, please let me know

zero0cool0 commented 3 years ago

I took a leap and activated the plugin, it seems to work but is still showing as incompatible. Like @willemjaap I'm more than happy to help with the coding to get this compatible again.

Murdock-droid commented 3 years ago

@zero0cool0 Thanks for giving it a shot. I also backed up everything, did the update, and activated the plugin and it does seem to be working. I started looking through the code to see how Piwigo is determining that the plugin is incompatible. I was hoping to find a MAX_COMPAT_VER_NO somewhere. So far, no luck.

haschmich commented 3 years ago

Might be worth asking in the Piwigo Forum. Would do it myself but cannot login currently because passwort reset does not work and the admin does not answer.

jdbonjour commented 3 years ago

The development of Piwigo is progressing very fast, these times (version 11.4.0 has just been released). It's boring that users of the piwigo-openstreetmap plugin are still stuck with Piwigo version 2.x. Does @xbgmsharp plan to do anything to make this plugin compatible with Piwigo 11.x ?

dmfisch commented 3 years ago

I would love to keep this plugin going, But I can't code and just give praises! Best regards! David https://map-mayenfisch.com/map/

xplosionmind commented 3 years ago

I would love to keep this plugin going, But I can't code and just give praises!

+1!

I would love this plugin to continue to be maintained!

Best, T

jose1711 commented 3 years ago

Please let me understand. The issue is (or may not be) with the plugin itself - only with the way how Piwigo is determining the compatibility. Is that correct?

bru500 commented 3 years ago

@jose1711 Yes. The Plugin got automatically deactivated with the update to Piwigo 11. Since I found out, that I could simply activate it again, it works as before on our site. Only it is marked as not compatible.

Murdock-droid commented 3 years ago

Ok. Since the plugin is functioning correctly, I wanted to learn what was making Piwigo determine that the plugin might be incompatible. So I started with THIS post, and then found THIS post that explained what was different with this version. So, it seems to be the admin menu change that is tripping the indicator to say that the plugin is incompatible.

I opened up the "main.inc.php" in the plugin folder, and added "Has Settings: webmaster" to the end of plugin name/description block at the top, and saved it. Then went to test it...and it didn't work...or so I thought. Because...now that I am looking at it weeks later...the warning message and alert icon are gone. I think I may have had to clear a cache or something. All I know is...they are gone now. (I am glad I didn't close those tabs weeks ago!)

Before: image

After: image

Here is the section of code I touched: (Note the "Has Settings..." at the bottom...that was what I added.)

<?php
/*
Plugin Name: OpenStreetMap
Version: 2.9.a
Description: OpenStreetMap integration for piwigo
Plugin URI: http://piwigo.org/ext/extension_view.php?eid=701
Author: xbmgsharp
Author URI: https://github.com/xbgmsharp/piwigo-openstreetmap
Has Settings: webmaster
*/

I hope this helps others, Murdock