search

Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
37 stars 35 forks source link

piwigo 12 compatibility #202

Closed tob123 closed 2 years ago

tob123 commented 3 years ago

Hello, can this plugin be made compatible to piwigo 12 ? from the piwigo admin page it is not installable on piwigo 12. thanks a whole bunch in advance.

EPTBSGL commented 2 years ago

I have the same request. The openstreetmap plugin version 2.9.a is not compatible with piwigo 12.1.0. Thank you in advance for your answers.

Fedena22 commented 2 years ago

Hey, what worked for me was to get the git-master zip and overwrite the old one. The version 2.9a is from 2018 so all bug fixed that were made prior to this tag are not available via the plugin version. It is a manual task and the plugin will still say that there was an error when activating it, but after I got back into the plugin config menu everything seams to work fine.

bhlevca commented 2 years ago

I just activated it even if I got the error and it works. There is no need to get it from github.

Bogdan

On Mon, 6 Dec 2021 at 14:53, Andreas Krampitz @.***> wrote:

Hey, what worked for me was to get the git-master zip and overwrite the old one. The version 2.9a is from 2018 so all bug fixed that were made prior to this tag are not available via the plugin version. It is a manual task and the plugin will still say that there was an error when activating it, but after I got back into the plugin config menu everything seams to work fine.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Piwigo/piwigo-openstreetmap/issues/202#issuecomment-987132484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMRXRWFCP2F5VPI5HTD2LUPUIE5ANCNFSM5HQCQEHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

EPTBSGL commented 2 years ago

Thanks for your quick responses. Indeed, despite the error displayed when activating the plugin, it works. Regards

demokrit2017 commented 2 years ago

Sadly there are massive issues under Piwigo 12.

E.g. on my side only the osmmap.php v1 is working anymore for the worldmap. On pictures with GPS coordinates the map is shown, but every second try an error appears. bulk tagging on location seems also not to be working anymore :( Also new pictures seem not to be included anymore, since I've upgrade to Piwigo 11 some time ago. An upgrade of the existing piwigo-OSM would be really, because it seems to be currently the only option to show the position of the picture in Piwigo and was one of the main reasons, why I've decided for Piwigo a few years ago.

ebiscaia commented 2 years ago

For me it is not working on Piwigo's latest version on Docker. I can see the plugins options and the globe icon, but not the map and if I click on the globe a new page is open and it shows:

HomeGo to Piwigo gallery
PreviousGo to back one page
0 items
Show AllShow all items in Piwigo gallery
Link to this mapShare this view
Find my positionSearch my position on the map
ebiscaia commented 2 years ago

After dealing with a new instance, I found out the plugins is working. However if you try to sync your file using the ftp it won't show the leaflet or any geo information. The trick is import a set of files and delete them,

gueba commented 2 years ago

Hi all, For me piwigo-openstreetmap works with version 12. I'm on hosted webspace with php 7.4. What I did:

general:

fix reverse geocoding:

syncing:

/ Die Datei ist nicht vorhanden und wird vom LocalFilesEditor erstellt. /

/ Add video support & special characters/ $conf['upload_form_all_types'] = true; $conf['sync_charsregex'] = '/^[a-zA-Z0-9-. ]+$/';

/ Add video metadata support / $conf['show_exif'] = true; $conf['show_exif_fields'] = array( 'Make', 'Model', 'ExifVersion', 'Software', 'DateTimeOriginal', 'FNumber', 'ExposureBiasValue', 'FILE;FileSize', 'ExposureTime', 'Flash', 'ISOSpeedRatings', 'FocalLength', 'FocalLengthIn35mmFilm', 'WhiteBalance', 'ExposureMode', 'MeteringMode', 'ExposureProgram', 'LightSource', 'Contrast', 'Saturation', 'Sharpness', 'bitrate', 'channel', 'date_creation', 'display_aspect_ratio', 'duration', 'filesize', 'format', 'formatprofile', 'codecid', 'frame_rate', 'latitude', 'longitude', 'make', 'model', 'playtime_seconds', 'sampling_rate', 'type', 'resolution', 'rotation', );

?>

OSWORLDMAP:
- edit files 
_piwigo-openstreetmap-master/template/osm-map2.tpl
piwigo-openstreetmap-master/template/osm-map3.tpl
piwigo-openstreetmap-master/template/osm-map4.tpl_

from original:

<!DOCTYPE html>

**{html_head}** {$GALLERY_TITLE} ...... ...... {html_style} ``` to : ``` **** {$GALLERY_TITLE} **{html_head}** ...... ...... {html_style} ``` So far, everything seems to be working as expected. hth
bhlevca commented 2 years ago

I don't think all this work is necessary. It works for me fine from the plugin repository. The only issue is that the plugin page lists it as incompatible. It would be nice if that would be fixed.

gueba commented 2 years ago

@bhlevca Sounds good, the fundamental function of showing a map did work for me, too. But without the changes the OSWORLDMAP only worked with version 1 as @demokrit2017 mentioned above. This is due to changes in the SMARTY-template-machine, I guess. Also reverse geocoding is broken, even in the master-branch (server is down). Do you happen to have these working in version 12 without changes? If I remember correctly, even showing *.gpx files did not work with the repository version.