Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
35 stars 35 forks source link

secure connection #21

Closed released14 closed 10 years ago

released14 commented 10 years ago

Please add an option to use a secure connection to openstreetmap.org (https instead of http). A simple check box in the options will do. Alternatively, a check whether piwigo itself uses and the appropriate behavior of the plugin would be sensefull, I guess. However, the check box allows for full user control and should be implemented easily.

xbgmsharp commented 10 years ago

Hello

Thanks for reporting. Will do the option as well as the check for the default behavior when global to PWG.

xbgmsharp commented 10 years ago

Alternatively you can use the custom URL field, and set it to HTTPS URL like: https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png

xbgmsharp commented 10 years ago

I did not make it as an configuration option because it can be done via the custom tiles field. Also most of tiles does not supports HTTPS. So I force usage of HTTPS as best practice for external URL and when possible for tiles. Could you review and tell me if it match you requirement.

released14 commented 10 years ago

I would suggest to add a note to the external URL field that mentions the possibility to use a secure connection with the corresponding example url. This will help non-experienced users to see this possibility and to take advantage of it. If it is not possible to use https in general, I agree in not using a config option, as this would lead to malfunction. Thanks for your fast reaction! I appreciate it as much as I like the extension.

xbgmsharp commented 10 years ago

There is no field and no change on the configuration page. As you can see in the commit, the external URL refer to "code.jquery.com" and "open.mapquestapi.com" for the search feature and the only tiles supporting HTTPS is "tile.openstreetmap.org".

That's it! ;)

xbgmsharp commented 10 years ago

Commit d5c5d43 solve the problem. No more HTTP call when possible. Closing no feedback