Question about file osmmap.php which is written to PHPWG_ROOT_PATH

Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo

http://piwigo.org/ext/extension_view.php?eid=701

GNU General Public License v3.0

37 stars 35 forks source link

Question about file osmmap.php which is written to PHPWG_ROOT_PATH #253

Closed zero0cool0 closed 5 months ago

zero0cool0 commented 7 months ago

I understand maintain.class.php is writing a file named osmmap.php into the root of the piwigo installation during the plugin installation process.

I'm curious to understand why it has to go into the piwigo root folder as this breaks the piwigo-upgrade process on my docker-based piwigo installation due to the official docker image default permission settings.

Wouldn't $conf['data-location'] be a better home for this file?

tfagart commented 7 months ago

I've got the same issue than you. Do you have a workaround for now ?

zero0cool0 commented 7 months ago

@tfagart I've created PR #254 and hope it will be accepted. It stores the osmmap.php file in another folder. For now, I'm installing the modified plugin manually, but that is clearly not a long term solution.

HWFord commented 5 months ago

pr merged on 11/06/2024