search

Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
37 stars 35 forks source link

Move generated osmmap.php file to _data folder instead of piwigo root folder #254

Closed zero0cool0 closed 5 months ago

zero0cool0 commented 7 months ago

Proposed pull request to address #253

zero0cool0 commented 6 months ago

@plegall any chance this PR could be considered by any of the maintainers?

boltgolt commented 6 months ago

Applied your PR locally and that allowed me to actually activate the plugin, thank you!

xbgmsharp commented 5 months ago

thanks

zero0cool0 commented 1 month ago

@xbgmsharp - I suggest to revert this PR as it does not really fix the issue for containerised Piwigo installations. Also, it breaks non-containerised instances, see #262

In containerised instances such as https://hub.docker.com/r/linuxserver/piwigo relative folder references such as './' from within osmmap.php do not work since the plugin folder as well as the _data folder reside outside the main piwigo root folder and are soft-linked into it.

Once the PR is reverted, the workaround is to manually create an empty osmmap.php file with the correct permissions in the Piwigo root folder every time the Piwigo docker image is updated.