Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
35 stars 35 forks source link

"Show items of this screen" should not always display #32

Closed GnunuX closed 9 years ago

GnunuX commented 10 years ago

If we do not select area, the like "Show items of this screen" didn't work (not lon/lat set so no href).

This patch (maybe not better solution for this issues) toggle on this like want user has selected a location.

--- osm-map.tpl.ori 2014-08-14 15:03:38.878058339 +0200
+++ osm-map.tpl 2014-08-14 15:06:40.994056764 +0200
@@ -29,7 +29,7 @@
 {/literal}
 {/html_style}

-<span> <a href="{$HOME}">{$HOME_NAME}</a> <a href="{$HOME_PREV}">{$HOME_PREV_NAME}</a> - <b id="nb_showall">{$TOTAL}</b> - <a id="showall" target="_blank" href="">Show items of this screen</a> - Mouse over a cluster to see the bounds of its children and click a cluster to zoom to those bounds</span>
+<span> <a href="{$HOME}">{$HOME_NAME}</a> <a href="{$HOME_PREV}">{$HOME_PREV_NAME}</a> - <b id="nb_showall">{$TOTAL}</b> - <a id="showall" target="_blank" href="" style="display: none">Show items of this screen</a><span id='shownothing'>Mouse over a cluster to see the bounds of its children and click a cluster to zoom to those bounds</span></span>
 <div id="map"></div>
 <script type="text/javascript">{$OSMJS}</script>

@@ -53,6 +53,8 @@
        var myurl = "{/literal}{$HOME}{literal}osmmap.php?min_lat="+min.lat+"&min_lng="+min.lng+"&max_lat="+max.lat+"&max_lng="+max.lng;
        //console.log(myurl);
        document.getElementById("showall").setAttribute('href',myurl);
+       document.getElementById("shownothing").style.display = 'none';
+       document.getElementById("showall").style.display = 'inline';

        var nb_items = 0;
        for (var i = 0; i < addressPoints.length; i++) {
xbgmsharp commented 10 years ago

Could you provide a pull request for that. Also using the version 2 layout.

xbgmsharp commented 9 years ago

Done on version1. version2 is more complex