search

Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
35 stars 35 forks source link

Feature request - add mini-map to albums #41

Closed evadim closed 9 years ago

evadim commented 9 years ago

I migrated from Menalto Gallery, and miss small thing: mini-map with album photos to sidebar in album view. (Now I see only button "display on map")

xbgmsharp commented 9 years ago

Hello, You might be lucky but this feature is implemented in the latest git source. Please test using the latest github source and feedback. https://github.com/xbgmsharp/piwigo-openstreetmap#installation

evadim commented 9 years ago

Jackpot! Looks nice, even better than I can imagine. Some comments. I want to use Grey Dragon+gdThumb. I think best variant for me is C_MAP 200x200, because it looks like photo. But, if I enable gdThumb/GThumb+ plugin - map "shift" all photos to the right. In this case, top right position inside gdThumb will be awesome. Also, about GPS files: will be good if I can "limit" GPS track to album, into which I upload it. And maybe some basic style elements(but I think this is planned).

Anyway, really nice work!

xbgmsharp commented 9 years ago

Thanks for the feedback. I will check gdThumb/GThumb+ plugin. All development is done on the default template. If you use any other template, you might need to adapt your it yourself via CSS. For the GPS files, by default you limit GPS track to 1 album. The tracks only appear when the specify album is show on the worldmap. What do you refer to by "limit"?

evadim commented 9 years ago

theme - I think I can't edit CSS now, but maybe this is good point to improve skills(if I found time).

For gps - Then I upload file, I choose one Album, actually it 3rd level inside my gallery, and I want to see track only then I see this album. Now, I also see track on World Map . If I add track for each album, map became completely unreadable, I think. Also, after I open link to map, it takes ~5-10 minutes for track to appear on map...

xbgmsharp commented 9 years ago

By default the track only appear on the the WorldMap and are not display on the web gallery. Not sure how to solve your request. The main goal is to show track location aside with the photo, so you can review your full track. I do believe the track file alone are not very useful, if you can see the photos link to it.

Do you wan the track file to also appear on album map know as 'Category's description'? Maybe I could add an option to display or not the tracks file on specific map, Picture map, World map, Categorie map, Memu map?

Would that help?

evadim commented 9 years ago

I do believe the track file alone are not very useful, if you can see the photos link to it.

I agree here.

My english not so good, and I think we don't undestand each other clearly :)

Do you wan the track file to also appear on album map know as 'Category's description'?

Err... I see track here, if I understand you correctly. :) In other words: I see track on every map, except of foto view, in which I even can't see baloon of current foto...

I think, would be good if I can choose where show track:

For example, show path to Album with checkboxes: [ ]main page \ [ ] Category 1 \ [ ] Category 2 \ [X] Album

Or it's OK if GPS file showed only inside the Album to which was uploaded and nowhere else... When I imagine how should look top level map with all my photos and for example 50 tracks at the same time, I think this is unusable — 50 crossing tracks become just visual noise...

P.S. and some gui for manage track will be good :)

cooltom commented 9 years ago

Hi, very good plugin! Please is there any way how to batch setup same GPS location for all photos in one album? For example as action in Batch manager - setup GPS for all photos in selected album(s). It will be usefull when you don't have GPS info in metadata and all photos are taken on one place.

xbgmsharp commented 9 years ago

@cooltom Please create a new issue for this query. Batch manager was including on previous version, I will add it again when confirm it should not be done in the PWG core. I fact in PWG there is a Geotagged pre-filter. Which apparently disappear on PWG. Maybe better to ask on the forum. http://piwigo.org/forum/viewtopic.php?pid=155331

@evadim Please note than I merge the code for the GPS track. Now I will think of it and come with a more complete solution.

xbgmsharp commented 9 years ago

The only way to make a correct and complete integration is to make the track file be as image. This way we can use all the core PWG feature like permission, album, etc...

xbgmsharp commented 9 years ago

GPS track should be handle like any other items (images). On the WorldMap, it should allow to show/hide the GPS layer, https://github.com/makinacorpus/Leaflet.FileLayer On the WorldMap, we could also to play the track on the map, https://github.com/hallahan/LeafletPlayback Maybe a global idea like this, https://github.com/stefanocudini/gpx-simplify-optimizer

evadim commented 9 years ago

awesome ideas!

xbgmsharp commented 9 years ago

A sample of a worldmap with a lot of track file. http://www.wikiloc.com/wikiloc/map.do

evadim commented 9 years ago

looks really good

xbgmsharp commented 9 years ago

Hello

Could you please test and feedback. Each tracks is display as an image item. This mean all GPX tracks file have all PWG features like permission, album, etc...

Note that you need to do a restore of the plugin. IMPORTANT: The MYSQL table is removed. The GPX files are also removed. Previous GPX entry are completely deleted. You need to import them again. This time using the PWG way.

gpx

gpx_batch_manager

evadim commented 9 years ago

Hello!

After git pull I try to reset module, and got error:

Parse error: syntax error, unexpected '' (T_ENCAPSED_AND_WHITESPACE), expecting identifier (T_STRING) or variable (T_VARIABLE) or number (T_NUM_STRING) in /var/www/***/htdocs/plugins/piwigo-openstreetmap/maintain.inc.php on line 121

I move module from fs and remove it as "broken", then move back. If I press activate - grt same error...

xbgmsharp commented 9 years ago

Oups, sorry. I committed a fixed. Thanks for testing.

evadim commented 9 years ago

After I switch lang, it says:

Notice: Undefined index: section in /var/www/***/htdocs/admin/plugin.php on line 32
Invalid plugin URL

But after press "back" in browser language actually changed

xbgmsharp commented 9 years ago

Which language did you switch to? Can you repeat the same action with only 1 plugin activate so we can isolated the issue.

evadim commented 9 years ago

Hm, seems I accidentally close issue :( Anyway - error with langs for appear every time then I switch english to russian and vice versa, but(!) only on page with OpenStreetMap plugin settings page. On another plugins swithcing lang transfer me to admin panel home page

I test a plugin a bit - looks awesome! Few questions:

<wpt lat="41.503070" lon="19.697155" >
<ele>13.6</ele>
<time>2013-09-15T17:51:28.000Z</time>
<name>wtf?!!</name>
</wpt>

Thanks for great work!

P.S not related to this, but... how can I add custom style with complicated config - HERE hybryd map for example?

xbgmsharp commented 9 years ago

error with langs for appear every time then I switch english to russian and vice versa, but(!) only on page with OpenStreetMap plugin settings page. On another plugins swithcing lang transfer me to admin panel home page

I try to change the language to RU, and I could not reproduce the issue. Do you have any message or log?

I have pic with "?" instead of special pic in your screenshots (I upload gpx file via FTP to existing album).

If you have VideoJS plugin install, there is a bug and you need to install it from the git repository. it prevent the correct MediaIcon to display correctly.

is it possipbe to parse and render waypoints? My GPS data logger make them then I press spesial button, like this:

It is possible to parse, but so far I did not find any good PHP library to parse GPX file.

is it possible to show photos on track?(not sure about that)

Could be interesting. However It will require to parse the GPX file prior in order to get all photo from the same zone and display them.

evadim commented 9 years ago

I try to change the language to RU, and I could not reproduce the issue. Do you have any message or log?

PHP Notice:  Undefined index: section in /var/www/my.piwigo.domain/htdocs/admin/plugin.php on line 32, referer: http://my.piwigo.domain/admin.php?page=plugin&section=piwigo-openstreetmap%2Fadmin%2Fadmin.php

Error also appear then I change theme in this menu. I try to clear cashes, change themes etc - no luck.

If you have VideoJS plugin install, <...>

Thanks for tip :)

xbgmsharp commented 9 years ago

http://my.piwigo.domain/admin.php?page=plugin&section=piwigo-openstreetmap%2Fadmin%2Fadmin.php If you use this URL, there is no warning.

If you use a reduce URL, you get the error. http://my.piwigo.domain/admin.php?page=plugin

I could not reproduce the issue.

evadim commented 9 years ago

Thanks for explanation. URL is, for example: http://my.piwigo.domain/admin.php?page=plugin&amp;section=piwigo-openstreetmap%2Fadmin%2Fadmin.php&ato_lang=en_US If I remove amp; - url works. So, it appear somehow in the url... Anyway, this thing not bug me a lot, since I use it only when testing plugin,