search

Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
35 stars 35 forks source link

popup on category and menu map #46

Open kaesi-jones opened 9 years ago

kaesi-jones commented 9 years ago

Hi, for sure I got a very simple problem. By clicking any marker no popup appears. What could that be? (I activated it in the configuration)

Thanks!

xbgmsharp commented 9 years ago

Thanks for the feedback. Could you please be more specific. How can I reproduce the issue? Could you try using the latest source from Github? And see if the problem still appear. I need to release a new version.

xbgmsharp commented 9 years ago

Which map do you refer to Photo-edit, Picture, Worldmap, ?

xbgmsharp commented 9 years ago

Any update on this? Can you please specify which map you refer to Photo-edit, Picture, Worldmap? I am not able to reproduce the issue.

velopeloton commented 9 years ago

Hi I'm new to this. I'm setting up a gallery for my website and want to use the osm with pointers for geolocated photos. The popup up pin on the category page don't work. They work on the worldmap. Anyone got any pointers as to where I need to look to fix it? http://velopeloton-cycling-pyrenees.bike/photo-gallery/

xbgmsharp commented 9 years ago

The popup up on pin is only enable on the world map. In fact the popup config is only on the world map configuration settings alias 'Left menu configuration'. Does it make sense to chow the image thumbnail in the category map or the menu map?

velopeloton commented 9 years ago

I think you may misunderstand me. On a category page. For instancs http://velopeloton-cycling-pyrenees.bike/photo-gallery/index.php?/category/3 Surly clicking on a pin on the map should show a thumbnail of the image and link to the photo. Otherwise what would be the point of having the map and pins on it. I'm sure I have seen it working on another site but I can't find it now.

xbgmsharp commented 9 years ago

Well I think I did understand what you mean ;) As mention, the popup up on pin is only enable on the world map. On each category page, you have a globe image (top left), that point to the world map. The category map is just a quick display therefor the popup is not available.

I will modify the code to allow it and/or make it as an option.

velopeloton commented 9 years ago

ok. Thanks for a great plugin. The fullscreen worldmap is fantastic,

xbgmsharp commented 9 years ago

I just check and you can easily make the behavior you are looking for. Edit the category.inc.php file on line 54 and change the value of 2 by 1. https://github.com/xbgmsharp/piwigo-openstreetmap/blob/master/category.inc.php#L54

Then you will get the popup with the thumbnail on the category. Is that what you are looking for?

I will move the popup settings in the 'Map configuration' section of the configuration page. This way they are global to all maps.

velopeloton commented 9 years ago

Yes, that's it. Brilliant! It opens in a new tab. Is it possible to open in the same browser tab?

xbgmsharp commented 9 years ago

It opens in a new tab because it was primary use on the world map page. There is no option for that. I will try to set it as the default behavior for category and menu map.

Edit the include/functions_map.php file on line 479 and remove target=\"_blank\" https://github.com/xbgmsharp/piwigo-openstreetmap/blob/master/include/functions_map.php#L479

compujeramey commented 9 years ago

Made the modification with ease, but would love for this to be included as standard functionality.