search

Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
35 stars 35 forks source link

No pin on right panel map #64

Closed antodippo closed 8 years ago

antodippo commented 9 years ago

I'm using the latest version available here on Github, and when I select image thumbnail as pin, there's no pin at all on the right panel map. It that by choice?

xbgmsharp commented 9 years ago

Yes it was by design. The pin option thumbnail did not apply to right panel map. However since the code has been factorize, it should be possible. So now it could be consider as a bug as it does generate an error.

Error: iconUrl not set in Icon options (see the docs).1 leaflet.js:7:12502

The SQL query does not generate the image thumbnail. This is a good reason to move to MYSQL View which is outstanding big work.

xbgmsharp commented 9 years ago

A quick fix would be to replace in file picture.inc.php on line 129:

$js_data = array(array($lat, $lon, null, null, null, null, null, null));

by 

$js_data = osm_get_items($page);

https://github.com/xbgmsharp/piwigo-openstreetmap/blob/master/picture.inc.php#L129

antodippo commented 9 years ago

Ok, thanks a lot.

xbgmsharp commented 9 years ago

It is not fix. osm_get_items show all image.

xbgmsharp commented 8 years ago

Fix via #77