search

Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
35 stars 35 forks source link

Source code contains full descriptions of all images in my album #66

Closed meulie closed 8 years ago

meulie commented 8 years ago

example URL: http://pub.meulie.net/picture/86-01_079_heemskerk_bij_assumburg

When I check out the source for this page I noticed it contains all markers from my entire album. This makes sense of course, because if I were to zoom out on the little map, more markers should show.

It also contains the complete description for all images in the entire album, plus image links. However... the markers aren't clickable, and only the image title appears when you hover over a marker. So all the image descriptions+URL's are is... overhead?

Is it an idea to exclude image descriptions/url's from these mini-maps?

xbgmsharp commented 8 years ago

Are you using the latest github version? I guess as this is bug introduce by a change for issue #64

meulie commented 8 years ago

Yup, I downloaded the latest version right before reporting this issue :)

xbgmsharp commented 8 years ago

Please revert commit from #64, a quick fix would be to replace in file picture.inc.php on line 129:

$js_data = osm_get_items($page);

by

$js_data = array(array($lat, $lon, null, null, null, null, null, null));

https://github.com/xbgmsharp/piwigo-openstreetmap/blob/master/picture.inc.php#L129

meulie commented 8 years ago

That does get rid of all the other markers, yes :)