search

Piwigo / piwigo-openstreetmap

OpenStreetMap integration for Piwigo
http://piwigo.org/ext/extension_view.php?eid=701
GNU General Public License v3.0
35 stars 35 forks source link

Possible to add KML support? #70

Open ThomasDaheim opened 8 years ago

ThomasDaheim commented 8 years ago

Hi,

since my track info is usually in KML I have hacked around to add KML support to the plugin. But I'm sure thats not the proper way of doing things :-) Any chance, that KML support might gets added to the plugin in the near future?

Thank! Thomas

xbgmsharp commented 8 years ago

I will look and see if there is a KML plugin for Leaflet.

ThomasDaheim commented 8 years ago

Yes, there is. And thats how I added KML support :-) Simple adding kml as extension into gpx.inc.php and have a separate osm-kml.tpl. But as I said, its just a hack and nothing to upload here :-)

xbgmsharp commented 8 years ago

Could you submit you code via pull request? It would be a good start.

ThomasDaheim commented 8 years ago

Sorry, I guess my non-existing knowledge of git process doesn't help here.

I have created a local branch "kml-support" and added my changes but my pull request fails "It seems you don't have permission to push your changes to this repository"...

xbgmsharp commented 8 years ago

You have to pull the change to your branch. Then you can make a pull request to my repository.

ThomasDaheim commented 8 years ago

Sorry, I always get "you don't have permission" - even when trying to Publish my commited local changes...

xbgmsharp commented 8 years ago
  1. you fork the repo
  2. you clone your new repo
  3. you apply your change
  4. you push your change to you repo.
  5. via the web UI you can create a pull request
ThomasDaheim commented 8 years ago

Thanks, seems to have worked without errors :-)