search

Piwigo / piwigo-videojs

Videojs port for piwigo. Play your videos on your web gallery!
http://piwigo.org/ext/extension_view.php?eid=610
GNU General Public License v3.0
67 stars 46 forks source link

Lightbox compatibility #127

Open ckong opened 6 years ago

ckong commented 6 years ago

(Major edit: Confused my plugins. I hope I got my question correct this time.)

Lightbox and VideoJS do not seem to work together. I've gotten syncronize to work, but found any added video will only display in the default theme (even though the Lightbox plugin is activated).

Videos added with the "Embedded Videos" plugin do work with Lightbox properly, but it's a very manual process.

Any chance of getting Lightbox and VideoJS compatible?

xbgmsharp commented 6 years ago

Could you provide the link of the plugin or theme you are referring to?

ckong commented 6 years ago

Thank you for the reply!

The Lightbox plugin is here: http://piwigo.org/ext/extension_view.php?eid=280.

It would be awesome if you could make this work, and allow manual input/override of the width/height.

For comparision, the plugin that I am using that works with Lightbox is Embedded Videos from here: http://piwigo.org/ext/extension_view.php?eid=136.

The embed code I'm using with this plugin is this:

<video width="640" height="360" controls preload="auto"> <source src="/piwigo/upload/videos/Test/my_video.mp4" type="video/mp4"> Your browser does not support the video tag. </video>

I am testing using your version of VideoJS github that fixes issue https://github.com/xbgmsharp/piwigo-videojs/issues/126 posted about 5 days ago (found it 2 days ago; it did fix that issue for me as well, but now I have this other problem).

jdev21 commented 5 years ago

It looks like lightbox works with embedded videos because they added the functionality to the plugin: http://piwigo.org/dev/browser/extensions/lightbox/get_content.php I, too, would like videojs to work with lightbox but I believe it needs integrated the other way around (through lightbox and not videojs). I tried changing some of the parameters in get_content from gvideo to piwigo-videojs but could not get it to work. I was not able to pour anymore time into it - hopefully someone else can come up with a solution.