Piwigo / piwigo-videojs

Videojs port for piwigo. Play your videos on your web gallery!
http://piwigo.org/ext/extension_view.php?eid=610
GNU General Public License v3.0
65 stars 45 forks source link

portrait video area in player v4 VS others #137

Open yarez0 opened 6 years ago

yarez0 commented 6 years ago

Hi guys,

I'm actually using the player v4 because video in portrait mode can be displayed without schrolling the page to the bottom of the page, put it un full screen then play with the option MAX SIZE (set to full HD for me)

why the other player does not have this option or is there a way to fit the portrait video in the screen area ? does the option RESOLUTION_DESC does this ? I can't test it, the button is always set to NO (maybe a translate problem ? I'm in french version and I saw this https://github.com/xbgmsharp/piwigo-videojs/issues/125 but I don't understand the purpose)

Landscape video fit the page area, the problem is only for portrait.

Piwigo 2.9.4 Système d'exploitation: Linux PHP: 7.2.9-1+020180901081133.4+stretch1.gbpdaac35 MySQL: 5.5.61 [2018-09-06 14:45:04] Bibliothèque graphique: External ImageMagick 6.9.7-4 theme bootstrap_default videojs 2.9.b

yarez0 commented 6 years ago

sorry in lanscape the video is oversized, no horizontal scroll bar, back to browser player

georg90 commented 5 years ago

I have the same issue using a combination of Bootstrap Darkroom theme (using the built in photoswipe) and videoJS.

Videos in landscape play just fine using the "browser" player. However, videos in portrait mode are off (see pictures below)

Okay (video thumb is centered, when clicked, video gets played in the same area: image

Not okay (thumb is in the correct area, when clicked, player is off the screen and starts playing but is not visible): image

tkuther commented 5 years ago

@georg90 PhotoSwipe in bootstrap darkroom bypasses the VideoJS library and uses native HTML5 with custom calculations, so this isn't related to piwigo-videojs.