Piwigo / piwigo-videojs

Videojs port for piwigo. Play your videos on your web gallery!
http://piwigo.org/ext/extension_view.php?eid=610
GNU General Public License v3.0
62 stars 44 forks source link

missing piwigo_image_videojs table #68

Open plegall opened 8 years ago

plegall commented 8 years ago

After installing a version 2.7.a (from piwigo.org/ext), I have overwritten files with the Github version (commit 185cf632b6ee913ccfd775c97bd20a1caa7ec31a)

In my database I don't have the piwigo_image_videojs table, even if it is supposed to be created in maintain.inc.php.

I think there are 2 issues:

1) we should use the PluginMaintain class, see how it's done on https://github.com/mistic100/Piwigo-Skeleton/blob/master/maintain.class.php

2) the version is always 2.7.a : on git master, you should use "version : auto". When you publish a new version on piwigo.org/ext, the version number will be automatically set.

kuzco1 commented 8 years ago

1) Same for me. Piwigo 2.8.1 and latest VideoJS 2.7a (direct download via the admin-gui in Piwigo). What what is this table ?

2) Fully agree. I have several versions from 2.7a for Piwigo 2.7.4 and 2.8.1

xbgmsharp commented 8 years ago

The videojs table is not use yet. https://github.com/xbgmsharp/piwigo-videojs/blob/master/maintain.inc.php#L93

Apparently using the git release system in piwigo.org/ext, there is some issue as some user complain about missing file. Not sure where you got the error but the creation of the table were activate. https://github.com/xbgmsharp/piwigo-videojs/commits/master/maintain.inc.php https://github.com/xbgmsharp/piwigo-videojs/commits/master/include/function_sync2.php

I will try to move the maintain.inc.php to use the PluginMaintain class, however if i recall I can't due the plugin name with -.