search

PiwikPRO / piwik-pro-sdk-framework-ios

MIT License
2 stars 2 forks source link

PiwikTracker sharedInstanceWithSiteID freezes main thread #2

Closed aeirola closed 3 years ago

aeirola commented 3 years ago

Using the SDK version 1.0.3 or later seems to freeze whenever PiwikTracker sharedInstanceWithSiteID is called after didFinishLaunchingWithOptions. This is reproducible in the Demo app (https://github.com/PiwikPRO/piwik-pro-sdk-demo-ios) by just upgrading the SDK pod to 1.0.3 or later. The issue doesn't seem to be present in version 1.0.1.

aeirola commented 3 years ago

In case anyone is maintaining this repository, I noticed that the old version of the SDK seems to be using the older UIWebView for something, since adding the SDK caused Apple App Store Connect to send a warning email stating

TMS-90809: Deprecated API Usage - App updates that use UIWebView will no longer be accepted as of December 2020. Instead, use WKWebView for improved security and reliability. Learn more (https://developer.apple.com/documentation/uikit/uiwebview).

I would imagine that newer versions of the SDK would have already moved to WKWebView, but as the newer versions of the SDK have issues with initialisation we are not able to update at the moment.

zaan commented 3 years ago

Thanks for the information about the issue. It will be investigated.

DreamEmulator commented 3 years ago

@aeirola this bug seems to have been fixed: https://github.com/PiwikPRO/piwik-pro-sdk-framework-ios/commit/e75fad87c802905fcc39f25e2828e38535115bba

aeirola commented 3 years ago

Yeah, this seems to be fixed now. Thanks Andrzej Mironowicz!