search

PiwikPRO / plugin-SiteMigration

Migrate websites and website data between two Piwik installations
17 stars 3 forks source link

Bugfix: invalid mapping action entries in the new site #22

Open Undergrounder opened 8 years ago

Undergrounder commented 8 years ago

Many of the action entries are invalid on the new site, when the old id is -1, 0 or null.

It can be reproduced in the integration tests that folow up this change (It has no sense to merge failling integration tests...).

I have seen, that some tests have failed. I will try to fix them the next week.

mattab commented 8 years ago

Hi @Undergrounder Thanks for the PR!

It can be reproduced in the tests.

Where could you see this bug in the tests? the build seems to pass, but maybe tests are not covering this use case? https://travis-ci.org/PiwikPRO/plugin-SiteMigration/jobs/81562722 - Maybe you could add some tests for it?

Undergrounder commented 8 years ago

Updated. It could be reproduced in the integration tests that follow up this change. I have now added some unit tests for this use case.