PiwikPRO / sdk-framework-android

0 stars 0 forks source link

Migrate to AndroidX Annotation #2

Closed MGaetan89 closed 2 years ago

MGaetan89 commented 2 years ago

In the POM file of this repository, we can see that you are using the Annotations Support Library, instead of AndroidX Annotation: https://github.com/PiwikPRO/sdk-framework-android/blob/eca6ab7d8d19377f5f125f2629ff477d29dfe22c/piwik-sdk-1.1.1.pom#L32-L37

Is it planned to migrate to AndroidX Annotation in a future release?

AndroidX libraries are Google's recommended libraries, as stated in the deprecated Support Library documentation:

Screenshot 2022-03-01 at 08 02 57
MGaetan89 commented 2 years ago

Any update on this issue?

MGaetan89 commented 2 years ago

FYI, with the stable release of Android Studio Chipmunk, there is a new feature to detect dependencies using old support libraries: https://android-developers.googleblog.com/2022/05/android-studio-chipmunk.html#:~:text=Build%20Analyzer%3A%20Check%20Jetifier

Piwik Pro is one of them: Screenshot from 2022-05-10 08-07-09

harmasz commented 2 years ago

Updating dependencies is currently on our agenda and we will be looking into bumping them in the next couple of weeks.

MGaetan89 commented 2 years ago

Any news on this?

MGaetan89 commented 2 years ago

It looks like this was addressed in 1.1.6. Thanks!