PiwikPRO / sdk-framework-android

0 stars 0 forks source link

Add missing dependency to `com.google.android.gms:play-services-ads-identifier` #3

Closed MGaetan89 closed 2 years ago

MGaetan89 commented 2 years ago

Recent releases of com.google.android.gms:play-services-basement no longer depend on com.google.android.gms:play-services-ads-identifier, preventing access to AdvertisingIdClient, which seems to be used by Piwik PRO.

Depending on how you currently use com.google.android.gms:play-services-basement, you might need to either:

The dependency currently used is declared in the POM file in this repository: https://github.com/PiwikPRO/sdk-framework-android/blob/eca6ab7d8d19377f5f125f2629ff477d29dfe22c/piwik-sdk-1.1.1.pom#L44-L49

MGaetan89 commented 2 years ago

Any update on this issue?

harmasz commented 2 years ago

Sorry for the long wait @MGaetan89. We are in the process of refactoring our Android SDK and we will be working on this in the coming weeks.

MGaetan89 commented 2 years ago

It looks like this was addressed in 1.1.6. Thanks!