Pix4D / cogito

Concourse resource for GitHub Commit Status and Google Chat notifications
MIT License
35 stars 14 forks source link

PCI-2665 Independent chat send add ability to specify sinks (put params) #107

Closed Esysc closed 1 year ago

Esysc commented 1 year ago

Part of: PCI-2665

This is the first part of the new feature, it's developed around put.params. The next PR will address the source resource configuration and it will complete the tests. Note also that the README will be updated accordingly in a separate PR.

What is this PR introducing?

Basically it adds a parameter sinks that can be specified in a put step. This new parameter is expected as a slice of strings and if nothing is specified it behaviors as before defaulting to all supported sinks. Currently only 2 are supported: github and gchat.

Example:

put step will only send to gchat, no Github status involved.

plan:
      - get: the-repo
        trigger: true
      - put: gchat
        params: 
         state: pending
         sinks: ["gchat"]
      ...

Best review commity by commit.

Todos

Esysc commented 1 year ago

I automatically closed the PR while renaming the branch.