Closed Esysc closed 1 year ago
Notes to reviewers:
Could you please update the PAT and rerun the CI for both PRs? We cannot merge with failing tests, and without passing tests we don't know what to review, the code could be proved wrong by the tests themselves. Merci.
Could you please update the PAT and rerun the CI for both PRs? We cannot merge with failing tests, and without passing tests we don't know what to review, the code could be proved wrong by the tests themselves. Merci.
Done!
Hello @Esysc, could you please mention here (and in the other PR) when all the outstanding comments have been answered, so that I can have an overview look? (no pressure, take your time!). Merci :-)
@Pix4D/integration , this PR is ready, I've addressed all the feedback I received until now. Note that it will be not merged as is, but after merging #109 that will add all the missing features and the test coverage.
The CI is failing because of test commit SHA reached the max statuses, however this is fixed in the next PR that will be merge onto this branch. For this reason I'd like to keep as is showing that this PR is not intended to be merged until the other one will be.
Rebased on #110, this will fix the CI
The squash of all the commits into one reveal that this PR could have been simply the first commit of #109 :-)
Closing, replaced by https://github.com/Pix4D/cogito/pull/113
Part of: PCI-2665
This is the first part of the new feature, it's developed around
put.params
. The next PR will address thesource
resource configuration and it will complete the tests. Note also that the README will be updated accordingly in a separate PR.What is this PR introducing?
Basically it adds a parameter
sinks
that can be specified in aput
step. This new parameter is expected as a slice of strings and if nothing is specified it behaviors as before defaulting to all supported sinks. Currently only 2 are supported:github
andgchat
.Example:
put
step will only send to gchat, no Github status involved.Best review commity by commit.
Todos