github: calculate sleep time based on Github server time

Pix4D / cogito

Concourse resource for GitHub Commit Status and Google Chat notifications

MIT License

35 stars 14 forks source link

Closed aliculPix4D closed 1 year ago

aliculPix4D commented 1 year ago

use date header reporting the server time to calculate the sleep time
add a jitter time to calculated sleep time to prevent creating a Thundering Herd
prevent negative sleep times. Minimal sleep time should be equal to jitter time

marco-m-pix4d commented 1 year ago

@aliculPix4D Let me know when you have gone through all the comments; if anything unclear, we can also have a chat if you prefer.

aliculPix4D commented 1 year ago

@marco-m-pix4d I addressed all your comments. Can you have a look again? I am espacially curious to hear your opinion on: https://github.com/Pix4D/cogito/pull/122/commits/26d0296e03f5c1f5c5af75393a7d662bc55c3dff

this is needed only to address your comment about negative sleep time:

log.Warning that an unexpected negative time has been detected

aliculPix4D commented 1 year ago

@Pix4D/integration request for a re-review. Thanks