PCI-3363 don't hardcode GitHub domain name

aliculPix4D commented 9 months ago

adds a possibility to configure source.github_hostname to allow for overriding of the GitHub hostname only from the tests. This helps us avoid a very ugly implementation with: os.Getenv("COGITO_GITHUB_API"). Default value is of course: github.com
this step forces us to remove the hardcoded github.com from basically everywhere
even the implicit dependency in Gchat putter that I reported is fixed (https://github.com/Pix4D/cogito/commit/362de679d8ba054f909d972f31b4796268f921bd)

We then later craft the API endpoint using: func apiEndpoint(h string) string function.

No tests were added, at least not for now. I think everything is covered by the existing tests. I could add the unit test for apiEndpoint function actually.

I will open a draft follow-up PR on top of this one, just to show you how simple will be to allow the GH Enterprise if this PR is merged.

marco-m-pix4d commented 8 months ago

@aliculPix4D I think we are almost there. I just left some comments on this apiEndpoint function.

aliculPix4D commented 8 months ago

@marco-m-pix4d @odormond ready for another round of review: https://github.com/Pix4D/cogito/pull/144/commits/f826246acc64f7f5b4775e000ca2b306d0f1d02a

Pix4D / cogito

PCI-3363 don't hardcode GitHub domain name #144