search

Pix4D / cogito

Concourse resource for GitHub Commit Status and Google Chat notifications
MIT License
35 stars 14 forks source link

sets: add the Add() method #156

Closed marco-m-pix4d closed 2 months ago

marco-m-pix4d commented 2 months ago

Part of PCI-3790

aliculPix4D commented 2 months ago

Also, I think we should start thinking about moving some of this small pkgs to its own repo away from cogito..

e.g. sets, retry etc...

It makes little sense to "depend" (not really but...) on cogito release

iAmoric commented 2 months ago

Also, I think we should start thinking about moving some of this small pkgs to its own repo away from cogito..

Ah, I am tempted to agree with this. I was already confused in the last PR. « ok we use this in fly_helper but why it’s in Cogito ? 🤔 »

marco-m-pix4d commented 2 months ago

To be 100% clear:

we do not depend on a cogito release; we simply depend on a go get github.com/Pix4D/cogito@master, which is clear and 100% pinned (@master is mapped to the git SHA of when "go get" is run).

I agree that it seems that we are almost ready to take the utility functions into their own (public) repo; when we begun, we didn't know how much reuse we would have had...