search

PixInsight / PCL

PixInsight Class Library
http://pixinsight.com/developer/pcl/
Other
42 stars 21 forks source link

Add gtests and some fixes found in testing #21

Closed kkretzschmar closed 8 years ago

kkretzschmar commented 8 years ago

Hi Juan, I found some time for testing the INDIClient on Linux and Windows. I found some issues and fixed them and overall I think we are now quite close for a first pre-release.

Did you find some time to do some testing on macos? If not what do you think can I do to help you in this regard.

Thanks, Klaus

jconejero commented 8 years ago

Hi Klaus, Thank you for the update. I've just merged your pull request. Sorry for the delay; I've been a bit more busy than usual with personal matters.

I've tested your module on Linux, and will test it on OS X and FreeBSD as soon as I release a new PCL version here. There should be no problems at all on these platforms, since both PCL and the INDI server are portable across Linux/UNIX.

Now that we have all platforms well synchronized (with the release of build 1198 for FreeBSD), we should prepare a first official release. Your module can be released as a regular update, but of course it must be announced officially on PixInsight Forum and through a massive email notification to all users. I'll prepare the email and will send the text to you before the release. Be ready for the atomic blast :)

kkretzschmar commented 8 years ago

Hi Juan,

I've tested your module on Linux, and will test it on OS X and FreeBSD as soon as I release a new PCL version here. Great!

There should be no problems at all on these platforms, since both PCL and the INDI server are portable across Linux/UNIX. During early development I was able to test the module on macos and Linux in parallel. I was using the Mac of my friend during his stay in US, now he is back and the Mac is gone :(...

but of course it must be announced officially on PixInsight Forum and through a massive email notification to all users. Sounds good ;)

I'll prepare the email and will send the text to you before the release. OK, thanks!

Be ready for the atomic blast :) :) Hopefully we do not get so many bug tickets. Maybe we need here also a special disclaimer. I think using the controller remotely can damage your equipment, e.g. you control your mount and you dont see that the telescope is hitting an obstacle. It should be clear that we cannot take any warranties in such cases.

Klaus

2016-03-08 11:46 GMT+01:00 Juan Conejero notifications@github.com:

Hi Klaus, Thank you for the update. I've just merged your pull request. Sorry for the delay; I've been a bit more busy than usual with personal matters.

I've tested your module on Linux, and will test it on OS X and FreeBSD as soon as I release a new PCL version here. There should be no problems at all on these platforms, since both PCL and the INDI server are portable across Linux/UNIX.

Now that we have all platforms well synchronized (with the release of build 1198 for FreeBSD), we should prepare a first official release. Your module can be released as a regular update, but of course it must be announced officially on PixInsight Forum and through a massive email notification to all users. I'll prepare the email and will send the text to you before the release. Be ready for the atomic blast :)

— Reply to this email directly or view it on GitHub https://github.com/PixInsight/PCL/pull/21#issuecomment-193720466.