Pixabay / jQuery-autoComplete

An extremely lightweight completion suggester plugin for jQuery that is used in production on Pixabay.com.
321 stars 116 forks source link

Autocomplete: Doesn't work with IME (input method editor) #21

Open vuongmn opened 9 years ago

vuongmn commented 9 years ago

Hi,

Please help me check this issue in Firefox, When in input japanese text, hiragana,kata.... It don't show list suggestion timely, After I press button Enter to confirm it will show list suggestion.

Best regards,

SimonSteinberger commented 9 years ago

That doesn't sound like a bug in the plugin itself ... Can you give more details?

vuongmn commented 9 years ago

Hi SimonSteinberger,

I give you some case that I have tested: Case 1: I input text in English in all browser, and it worrk OK. I'm using verssion: 1.0.5. When I use case 'down', 'up' to choice the suggestion item, And I press the Enter key, It doesn't hide list suggestion(like choose by mouse click), Library will call another request to suggest for item selected. And I see the upgrade to version 1.0.6 to fix this problem. I have try upgraded, and it fixed my case, ok all browser.

Case 2:

Input japanese text(ひと) hiragana, It work ok all browser, It suggest timely when I type in textbox. But in Firefox it doesn't;

After I input japanese text: ひと It doesn't suggest. After I press key Enter for changing to confirm of japanese it will show list suggestion for me. I've research in many sites and I've know reason is Japanese IME. But after I upgraded to version 1.0.6, It fix issue enter selected suggestion item, But It doesn't work in Firefox "Case 2"

I have read source code, and I see that: // enter else if (e.which == 13) { var sel = $('.autocomplete-suggestion.selected', that.sc); if (sel.length) { o.onSelect(e, sel.data('val'), sel); setTimeout(function(){ that.sc.hide(); }, 10); } }

that.on('keyup.autocomplete', function(e){ if (!~$.inArray(e.which, [13, 27, 38, 40, 37, 39])) { var val = that.val(); . . . This code prevent this suggest in firefox when type japanese texx, And it fix the issues enter selected suggestion item.

Do you know the solution to fix this, thank in advance.

SimonSteinberger commented 9 years ago

Unfortunately, it's really hard to simulate the issue for me here. If you - or anybody else - finds a solution, I'll gladly include it in the GitHub repo.