search

PixarAnimationStudios / OpenSubdiv

An Open-Source subdivision surface library.
graphics.pixar.com/opensubdiv
Other
2.88k stars 558 forks source link

fix opengl loader include error when build with opengl and examples #1257

Closed Danielmelody closed 2 years ago

Danielmelody commented 2 years ago

when config with -DNO_OPENGL=OFF -DNO_EXAMPLES=OFF we will get glLoader.h not found error, this is caused by in-consistent OPENGL and GLFW config in cmake

davidgyu commented 2 years ago

Hi, would you submit a CLA Thank you!

Danielmelody commented 2 years ago

@davidgyu Just sent, please have a look.

davidgyu commented 2 years ago

Thanks!

davidgyu commented 2 years ago

Can you also change the base branch of this PR to the 'dev' branch. We don't directly update the release branch.

Danielmelody commented 2 years ago

@davidgyu Done.

davidgyu commented 2 years ago

Filed as internal issue #OSD-386

Danielmelody commented 2 years ago

Can I signed a CLA for a github organization? We want do more contributions, but we don't have a common e-mail address, it could save a lot of time if so.

Danielmelody commented 2 years ago

Or perhaps utilizing tools like https://github.com/cla-assistant/cla-assistant or https://github.com/apps/cla-bot could make it easier for anyone to make contributions.

davidgyu commented 2 years ago

There is a corporate CLA form that an officer of your company can sign and identify a list of participating contributors. This isn't specifically tied to a GitHub organization. Agree that automation of this process would be nice, but we don't have that in place at the moment.

davidgyu commented 2 years ago

Thanks!