search

PixarAnimationStudios / OpenSubdiv

An Open-Source subdivision surface library.
graphics.pixar.com/opensubdiv
Other
2.88k stars 558 forks source link

added additional compiler flags to remove warnings created on ninja build #1273

Closed roquo closed 1 year ago

roquo commented 2 years ago

Issue: Compile errors while building with Ninja Release 3_4_4

davidgyu commented 1 year ago

Filed as internal issue #OSD-391

davidgyu commented 1 year ago

Thanks for taking a look at this. The direction we'd like to take is to have a consistent set of compiler flags for MSVC regardless of generator, i.e. not ninja specific.

roquo commented 1 year ago

@davidgyu So does that mean the ignored warnings should be added directly for MSVC? I am not sure why the warnings only come up with the Ninja generator and not with Visual Studio. It would be a great help for me to directly support ninja without applying patches. Thanks! I am going to update the pull request