CMake: append should be used for CMAKE_MODULE_PATH

PixarAnimationStudios / OpenSubdiv

An Open-Source subdivision surface library.

graphics.pixar.com/opensubdiv

Other

2.89k stars 561 forks source link

CMake: append should be used for CMAKE_MODULE_PATH #1296

Closed CraigHutchinson closed 1 year ago

CraigHutchinson commented 1 year ago

Description of Change(s)

CMAKE_MODULE_PATH is a directory list and shall be appended via list(APPEND

Additionally hardened paths by using PROJECT_SOURCE_DIR

Note

No major change but ensures when CMAKE_MODULE_PATH has been defined with alternative defaults on the command-line or via use of CMAKE_PROJECT_TOP_LEVEL_INCLUDES

davidgyu commented 1 year ago

Filed as internal issue #OSD-408

davidgyu commented 1 year ago

Hi Craig! Could you submit or add yourself to an OpenSubdiv CLA This is distinct from the USD agreement. Thanks!

davidgyu commented 1 year ago

We've got your corporate CLA. Thanks, Craig!