search

PixarAnimationStudios / OpenSubdiv

An Open-Source subdivision surface library.
graphics.pixar.com/opensubdiv
Other
2.88k stars 558 forks source link

Updated C++ standard to C++14 #1297

Closed davidgyu closed 1 year ago

davidgyu commented 1 year ago

Updated C++ standard to C++14

The OpenSubdiv public interface currently requires only C++11 but we choose this version since C++14 has been the default since GCC 6, Clang 6, and Visual Studio 2017 (for the most part) and C++14 has been the default for OpenSubdiv on macOS when support for Metal is enabled.

This setting is guarded so that it can be overridden by the caller when running CMake.

Fixes #1276

davidgyu commented 1 year ago

Filed as internal issue #OSD-375

meshula commented 1 year ago

fyi, this just came up on the USD repo

https://github.com/PixarAnimationStudios/USD/pull/2339

perhaps that slightly guarded approach makes sense?

davidgyu commented 1 year ago

Agree with @meshula that we'd like a solution that works well for use cases like the sub-project and also is consistent with the USD repo.