Closed waywardmonkeys closed 1 year ago
Filed as internal issue #0SD-424
As noted here: 3.x Hbr Overview and here 3.5 Release Notes the code in opensubdiv/hbr
is deprecated and slated for removal at some point in the future. We're reluctant to merge changes into this part of the codebase.
We are looking into adding a NO_HBR
option which hopefully would help you out here.
Thanks!
I hadn't seen that. Would an external PR to add such an option be of interest or will you just do it internally?
A PR would be welcome but be forewarned that there are currently dependencies on hbr in the regression tests which complicates implementing such a NO_HBR option.
Marking this closed per discussion above.
While it was iterating over the faces and calculating counts,
numfaces
was being incremented, but thennfaces
was used. These would differ if there was a null face.Found when using roughly current compilers for emscripten and a WebAssembly build.