PixarAnimationStudios / OpenSubdiv

An Open-Source subdivision surface library.
graphics.pixar.com/opensubdiv
Other
2.88k stars 558 forks source link

Incorrectly duplicated code #1311

Closed ikolev21 closed 1 year ago

ikolev21 commented 1 year ago

In src/SeExpr2/UI/ExprCurve.cpp , ExprCurve::openDetail(), lines 432-439 are verbatim copy of lines 423-430.

This looks like a copy-paste bug, I don't see any reason why the block of code within if (dialog->exec() == QDialog::Accepted) should be repeated twice.

ikolev21 commented 1 year ago

Sorry, wrong repo, this was for SeExpr

davidgyu commented 1 year ago

We go ahead and delete this issue. Thanks!