Open Cory-Kramer opened 1 year ago
Filed as internal issue #OSD-429
My understanding is that [[fallthrough]] was introduced in C++17. At this point, OpenSubdiv does not use any features specific to C++17, so this change will make C++17 a new minimum requirement to build it.
@davidgyu, the USD repository contains similar code for its internal hashing. In the spirit of keeping Pixar's projects reasonably aligned, has the issue of how/when to suppress similar fall-through warnings been raised there?
That's right, we're not ready to make changes to the code that would require C++17.
This hasn't been addressed yet in the OpenUSD code base. There is work in progress to align with recent vfx platform versions which specify C++17 and when that work is complete we will consider incorporating C++17 specific features.
I added
[[fallthrough]]
attributes to case statements when fallthrough behavior was intended.Fixes build warnings
-Wimplicit-fallthrough
.