search

PixarAnimationStudios / OpenSubdiv

An Open-Source subdivision surface library.
graphics.pixar.com/opensubdiv
Other
2.88k stars 558 forks source link

allow absolute GNU install dirs #1315

Open chayleaf opened 1 year ago

chayleaf commented 1 year ago

CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR are allowed to be absolute as per CMake docs, so they shouldn't be concatenated to absolute paths. Instead, use CMAKE_INSTALL_FULL_LIBDIR and CMAKE_INSTALL_FULL_INCLUDEDIR, which are known to be absolute.

Absolute CMAKE_INSTALL_*DIR paths are used at least on NixOS. This is because NixOS packages are allowed to have multiple outputs (e.g. put docs in one dir, headers and other files for development to another, the binaries to a third one), and NixOS isn't FHS-compliant (There's no /usr, each package output has its own directory instead).

GNU Guix is a similar distro, but I'm not sure how CMake packages are built there. Either way, it's good to fully conform to the spec.

davidgyu commented 1 year ago

Filed as internal issue #OSD-430

davidgyu commented 1 year ago

Hi, @chayleaf would you submit a CLA Thanks!

chayleaf commented 1 year ago

Just did that