search

PixarAnimationStudios / OpenSubdiv

An Open-Source subdivision surface library.
graphics.pixar.com/opensubdiv
Other
2.89k stars 561 forks source link

Marked deprecated Osd::*Evaluator::SetNumThreads() #1317

Closed davidgyu closed 1 year ago

davidgyu commented 1 year ago

The existing implementation in Osd::TbbEvaluator has never been implemented correctly and that implementation is incompatible with the oneTBB API.

These methods are now marked deprecated in the two places where defined in Osd::TbbEvaluator and Osd::OmpEvaluator, but for consistency we preserve the existing implementation when building with older versions of tbb.

We've already removed all use of these methods from the tests and examples.

Fixes #1211 #1234 #1307

davidgyu commented 1 year ago

These changes have been tested on Windows, Linux, and macOS using TBB 2018 Update 6, TBB 2020 Update 3 and oneTBB 2021.10.0

davidgyu commented 1 year ago

Reviewed internally along with additional testing.