PixarAnimationStudios / OpenSubdiv

An Open-Source subdivision surface library.
graphics.pixar.com/opensubdiv
Other
2.89k stars 561 forks source link

Fixed inconsistent warning levels for MSVC builds #1318

Closed davidgyu closed 1 year ago

davidgyu commented 1 year ago

The MSVC build has been setting /W3 as an override for /Wall but this has been causing generator specfic build inconsistencies.

For examples, this override works when using the Visual Studio generators, but not when using the Ninja generator. This causes Ninja to build using /Wall instead of /W3.

This removes the initial setting of /Wall to avoid this inconsistency.

We plan to continue to address compiler warnings to allow us to raise this warning level further but that is a separate task.

Thanks to @LazyDodo for diagnosing the root cause of this inconsistency

Fixes #1269 #1283

davidgyu commented 1 year ago

Reviewed internally.