PixarAnimationStudios / OpenSubdiv

An Open-Source subdivision surface library.
graphics.pixar.com/opensubdiv
Other
2.88k stars 558 forks source link

Fixed rare topological bug creating patches at valence-2 darts #1336

Closed barfowl closed 2 months ago

barfowl commented 2 months ago

The case of a valence-2 dart vertex (a valence-2 interior vertex with a single infinitely sharp edge) has never been addressed correctly when constructing patches for the limit surface. The logic in the Far::PatchBuilder class that creates the patches does not account for the combined presence of valence-2 interior vertices and darts -- both of which require special handling -- and will usually crash.

Changes here include two commits: