search

PixarAnimationStudios / OpenUSD

Universal Scene Description
http://www.openusd.org
Other
5.99k stars 1.18k forks source link

USDView - OpenColorIO 2 GPU support incomplete #1924

Open remia opened 2 years ago

remia commented 2 years ago

It seems that the support for OCIO v2 (from https://github.com/PixarAnimationStudios/USD/commit/b08e77faea3b46105fe866c37d0d7c25152e5ce6) is currently broken as it's trying to use the new GPU path (via getDefaultGPUProcessor()) but fail to then setup all the resources required (there is now an arbitrary number of 1D and 3DLUTs to query). While in may work on LUTs free config like the newer ACES configs, it will break on other configs. This was also discussed in https://github.com/PixarAnimationStudios/USD/issues/1386 I believe.

A quick fix could be to use the Legacy GPU Processor in v2.0.1, then potentially migrate to a v2 compliant GPU path, an example being available in Python here.

sunyab commented 2 years ago

Filed as internal issue #USD-7460

spiffmon commented 2 years ago

Thanks for filing, @remia . Pixar has not yet transitioned to 2.x, and we accepted the referenced PR with the understanding that we couldn't yet really validate or support it. We would consider a further PR that completes the work, though!

creijon commented 2 years ago

I've put a PR with OCIO 2.1.1 GPU support for Metal and OpenGL here: https://github.com/PixarAnimationStudios/USD/pull/1936