PixarAnimationStudios / OpenUSD

Universal Scene Description
http://www.openusd.org
Other
6.12k stars 1.22k forks source link

usdview silent crash #2478

Open hybridherbst opened 1 year ago

hybridherbst commented 1 year ago

Description of Issue

Another silent crash when opening a file.

Steps to Reproduce

  1. Download Needle-MadeWithNeedle-20230607-140834.zip
  2. Open in usdview
  3. Crash

System Information (OS, Hardware)

Windows 11, RTX2070

Just to clarify, I'm not looking for help with these specific files (I'll figure out what's wrong with them) but rather the overall usability of usdview for inspecting and understanding USD files.

Generally it would be great if usdview could output actionable info when parsing errors happen – currently I always have to open Omniverse and that then logs something like

2023-06-07 12:14:43  [Error] [omni.usd] Runtime Error (secondary thread): in textFileFormatYyerror at line 3110 of pxr/usd/sdf/textFileFormat.yy -- Error parsing simple value: Failed to parse value (at sub-part 0 if there are multiple parts) at 'undefined' in </Materials/Material_17/PreviewSurface.inputs:roughness> on line 1263 in file C:\Users\herbst\Downloads\Needle-MadeWithNeedle-20230607-140834.usdz[model.usda]
2023-06-07 12:14:43  [Error] [omni.usd] Runtime Error (secondary thread): in textFileFormatYyerror at line 3110 of pxr/usd/sdf/textFileFormat.yy -- Error parsing simple value: Failed to parse value (at sub-part 0 if there are multiple parts) at 'undefined' in </Materials/Material_17/PreviewSurface.inputs:metallic> on line 1264 in file C:\Users\herbst\Downloads\Needle-MadeWithNeedle-20230607-140834.usdz[model.usda]
2023-06-07 12:14:43  [Error] [omni.usd] Failed to open : C:/Users/herbst/Downloads/Needle-MadeWithNeedle-20230607-140834.usdz

and there's this in the file, clearly wrong, but hard to find if apps just crash silently :)

            float inputs:roughness = undefined
            float inputs:metallic = undefined
jesschimein commented 1 year ago

Filed as internal issue #USD-8408