OCIO DisplayViewTransform uses display name as colourspace if display_colorspace is <USE_DISPLAY_NAME> in OCIO config

PixarAnimationStudios / OpenUSD

Universal Scene Description

http://www.openusd.org

Other

5.45k stars 1.13k forks source link

OCIO DisplayViewTransform uses display name as colourspace if display_colorspace is <USE_DISPLAY_NAME> in OCIO config #3017

Open jonahjnewton opened 1 month ago

jonahjnewton commented 1 month ago

OCIO DisplayViewTransform uses display name as colourspace if display_colorspace is in OCIO config

Description of Change(s)

OCIO 2 allows View transforms in an OCIO config to set their display_colorspace to to use the Display name to find the display colorspace. Usdview does not handle this, and therefore errors stating that it can't find a colorspace named .

This change adds a simple check to use the display name as the colorspace in Usdview if the incoming colorspace is .

Fixes Issue(s)

No existing issues that I can find

[x] I have verified that all unit tests pass with the proposed changes
[x] I have submitted a signed Contributor License Agreement

jesschimein commented 1 month ago

Filed as internal issue #USD-9485

jesschimein commented 1 month ago

/AzurePipelines run

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

tcauchois commented 1 week ago

Hey Jonah,

My understanding from the OCIO folks is that should be entirely an internal OCIO detail, and client code shouldn't need to worry about it at all. Can you give us some more information, like where the "" is coming from (is it OCIO.GetCurrentConfig().getColorSpaces()?) and which error you're hitting exactly?

Thanks, Tom

jonahjnewton commented 3 days ago

Hey Tom, I'm simply loading an OCIO config with a View that contains the keyword, and then applying that view transform in the OCIO section of USDview. The error that comes up in the USDview terminal states that it can't find a colorspace named , which I understand should be recognised by OCIO and then translated to the display colorspace.

The same OCIO install works in multiple other applications just fine, so I'm unsure why it would be happening only with USDview, but that's the issue I'm encountering.

tcauchois commented 3 days ago

Got it, thanks. Could you paste the terminal output?

jonahjnewton commented 3 days ago

I just get this line as the terminal output: ERROR: Usdview encountered an error while rendering.DisplayViewTransform error. Cannot find source color space named '<USE_DISPLAY_NAME>'.